Skip to content

go_1_25: 1.25.0 -> 1.25.1#441005

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
c4patino:feat/update/go_1_25
Sep 7, 2025
Merged

go_1_25: 1.25.0 -> 1.25.1#441005
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
c4patino:feat/update/go_1_25

Conversation

@c4patino
Copy link
Contributor

@c4patino c4patino commented Sep 7, 2025

updated go_1_25 version from 1.25.0 -> 1.25.1.

Closes #440982

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@llakala
Copy link
Contributor

llakala commented Sep 7, 2025

We both made a PR at the same exact minute! #441006

I can close mine, if you prefer.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. labels Sep 7, 2025
@c4patino
Copy link
Contributor Author

c4patino commented Sep 7, 2025

We both made a PR at the same exact minute! #441006

I can close mine, if you prefer.

Lmao thats great! Quick on the trigger with issues. I have a nixpkgs-review-gha running at the moment so we can use mine since thats coming through. Please do review though since you already know the diff 😁.

@llakala llakala mentioned this pull request Sep 7, 2025
13 tasks
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 7, 2025
@SuperSandro2000 SuperSandro2000 merged commit bccf34f into NixOS:master Sep 7, 2025
33 of 36 checks passed
@c4patino c4patino deleted the feat/update/go_1_25 branch September 7, 2025 21:43
@SuperSandroBot
Copy link

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 441005
Commit: f68798a02e30b181515eceef1dc867fad7a12ced (subsequent changes)
Merge: 6ba9b1787d6a880b1148bf5d527a515d3974b8db

Logs: https://github.com/SuperSandro2000/nixpkgs-review-gha/actions/runs/17533190530


x86_64-linux

✅ 29 packages built:
  • bluetuith
  • caddy
  • delve
  • dnscontrol
  • evcc
  • go-camo
  • go_1_25 (go_latest)
  • golangci-lint
  • golangci-lint-langserver
  • gopls
  • goreleaser
  • gotenberg
  • gotenberg.hyphen
  • govulncheck
  • helmfile
  • helmfile-wrapped
  • pocket-id
  • readeck
  • sshwifty
  • styx
  • styx.lib
  • styx.themes
  • terraform-providers.talos
  • terragrunt
  • typescript-go
  • upcloud-cli
  • wakapi
  • wox
  • ycmd

aarch64-linux

✅ 29 packages built:
  • bluetuith
  • caddy
  • delve
  • dnscontrol
  • evcc
  • go-camo
  • go_1_25 (go_latest)
  • golangci-lint
  • golangci-lint-langserver
  • gopls
  • goreleaser
  • gotenberg
  • gotenberg.hyphen
  • govulncheck
  • helmfile
  • helmfile-wrapped
  • pocket-id
  • readeck
  • sshwifty
  • styx
  • styx.lib
  • styx.themes
  • terraform-providers.talos
  • terragrunt
  • typescript-go
  • upcloud-cli
  • wakapi
  • wox
  • ycmd

x86_64-darwin (sandbox = true)

❌ 3 packages failed to build:
  • go-camo
  • pocket-id
  • wakapi
✅ 21 packages built:
  • caddy
  • delve
  • dnscontrol
  • evcc
  • go_1_25 (go_latest)
  • golangci-lint
  • golangci-lint-langserver
  • gopls
  • goreleaser
  • govulncheck
  • helmfile
  • helmfile-wrapped
  • readeck
  • styx
  • styx.lib
  • styx.themes
  • terraform-providers.talos
  • terragrunt
  • typescript-go
  • upcloud-cli
  • ycmd

Error logs: `x86_64-darwin`
go-camo
testing.tRunner.func1.2({0x1049a9260, 0xc0000441d0})
	/nix/store/ygzywlf0xadh6za6xdwn1n9mrws7pwvk-go-1.25.1/share/go/src/testing/testing.go:1872 +0x237
testing.tRunner.func1()
	/nix/store/ygzywlf0xadh6za6xdwn1n9mrws7pwvk-go-1.25.1/share/go/src/testing/testing.go:1875 +0x35b
panic({0x1049a9260?, 0xc0000441d0?})
	/nix/store/ygzywlf0xadh6za6xdwn1n9mrws7pwvk-go-1.25.1/share/go/src/runtime/panic.go:783 +0x132
net/http/httptest.newLocalListener()
	/nix/store/ygzywlf0xadh6za6xdwn1n9mrws7pwvk-go-1.25.1/share/go/src/net/http/httptest/server.go:71 +0xda
net/http/httptest.NewUnstartedServer(...)
	/nix/store/ygzywlf0xadh6za6xdwn1n9mrws7pwvk-go-1.25.1/share/go/src/net/http/httptest/server.go:119
net/http/httptest.NewServer({0x104a8e260, 0xc00007e660})
	/nix/store/ygzywlf0xadh6za6xdwn1n9mrws7pwvk-go-1.25.1/share/go/src/net/http/httptest/server.go:106 +0x25
github.com/cactus/go-camo/v2/pkg/camo.TestTimeout(0xc000184540)
	/nix/build/nix-build-go-camo-2.6.5.drv-7451-2769720135/source/pkg/camo/proxy_timeout_test.go:37 +0x16a
testing.tRunner(0xc000184540, 0x104a87840)
	/nix/store/ygzywlf0xadh6za6xdwn1n9mrws7pwvk-go-1.25.1/share/go/src/testing/testing.go:1934 +0xea
created by testing.(*T).Run in goroutine 1
	/nix/store/ygzywlf0xadh6za6xdwn1n9mrws7pwvk-go-1.25.1/share/go/src/testing/testing.go:1997 +0x465
FAIL	github.com/cactus/go-camo/v2/pkg/camo	1.127s
FAIL
pocket-id
Building subPackage ./internal/utils/cookie
Building subPackage ./internal/utils/crypto
Building subPackage ./internal/utils/email
Building subPackage ./internal/utils/image
Building subPackage ./internal/utils/jwk
Building subPackage ./internal/utils/signals
Building subPackage ./internal/utils/sqlite
Building subPackage ./internal/utils/systemd
Building subPackage ./internal/utils/testing
Building subPackage ./resources
buildPhase completed in 11 minutes 48 seconds
Running phase: checkPhase
@nix { "action": "setPhase", "phase": "checkPhase" }
panic: open /etc/protocols: operation not permitted

goroutine 1 [running]:
modernc.org/libc/honnef.co/go/netdb.init.0()
/nix/build/nix-build-pocket-id-1.10.0.drv-7451-2769720143/source/backend/vendor/modernc.org/libc/honnef.co/go/netdb/netdb.go:700 +0x713
FAIL github.com/pocket-id/pocket-id/backend/internal/bootstrap 1.998s
FAIL

wakapi
Building subPackage ./routes/relay
Building subPackage ./routes/utils
Building subPackage ./services
Building subPackage ./services/imports
Building subPackage ./services/mail
Building subPackage ./static/docs
Building subPackage ./utils
Building subPackage ./utils/fs
Building subPackage ./views
Building subPackage ./views/mail
buildPhase completed in 4 minutes 22 seconds
Running phase: checkPhase
@nix { "action": "setPhase", "phase": "checkPhase" }
panic: open /etc/protocols: operation not permitted

goroutine 1 [running]:
modernc.org/libc/honnef.co/go/netdb.init.0()
/nix/build/nix-build-wakapi-2.15.0.drv-7451-2769720150/source/vendor/modernc.org/libc/honnef.co/go/netdb/netdb.go:700 +0x713
FAIL github.com/muety/wakapi/config 1.087s
FAIL


aarch64-darwin (sandbox = true)

❌ 3 packages failed to build:
  • go-camo
  • pocket-id
  • wakapi
✅ 21 packages built:
  • caddy
  • delve
  • dnscontrol
  • evcc
  • go_1_25 (go_latest)
  • golangci-lint
  • golangci-lint-langserver
  • gopls
  • goreleaser
  • govulncheck
  • helmfile
  • helmfile-wrapped
  • readeck
  • styx
  • styx.lib
  • styx.themes
  • terraform-providers.talos
  • terragrunt
  • typescript-go
  • upcloud-cli
  • ycmd

Error logs: `aarch64-darwin`
go-camo
testing.tRunner.func1.2({0x100f9f140, 0x14000042540})
	/nix/store/hdbabk78d03sxbgbalhnqzi0v94yzq8c-go-1.25.1/share/go/src/testing/testing.go:1872 +0x190
testing.tRunner.func1()
	/nix/store/hdbabk78d03sxbgbalhnqzi0v94yzq8c-go-1.25.1/share/go/src/testing/testing.go:1875 +0x31c
panic({0x100f9f140?, 0x14000042540?})
	/nix/store/hdbabk78d03sxbgbalhnqzi0v94yzq8c-go-1.25.1/share/go/src/runtime/panic.go:783 +0x120
net/http/httptest.newLocalListener()
	/nix/store/hdbabk78d03sxbgbalhnqzi0v94yzq8c-go-1.25.1/share/go/src/net/http/httptest/server.go:71 +0xd4
net/http/httptest.NewUnstartedServer(...)
	/nix/store/hdbabk78d03sxbgbalhnqzi0v94yzq8c-go-1.25.1/share/go/src/net/http/httptest/server.go:119
net/http/httptest.NewServer({0x101083ee0, 0x14000042500})
	/nix/store/hdbabk78d03sxbgbalhnqzi0v94yzq8c-go-1.25.1/share/go/src/net/http/httptest/server.go:106 +0x28
github.com/cactus/go-camo/v2/pkg/camo.TestServerChunkTooBig(0x14000223180)
	/nix/build/nix-build-go-camo-2.6.5.drv-18387-3763314644/source/pkg/camo/proxy_timeout_test.go:259 +0xe4
testing.tRunner(0x14000223180, 0x10107d4b0)
	/nix/store/hdbabk78d03sxbgbalhnqzi0v94yzq8c-go-1.25.1/share/go/src/testing/testing.go:1934 +0xc8
created by testing.(*T).Run in goroutine 1
	/nix/store/hdbabk78d03sxbgbalhnqzi0v94yzq8c-go-1.25.1/share/go/src/testing/testing.go:1997 +0x364
FAIL	github.com/cactus/go-camo/v2/pkg/camo	0.030s
FAIL
pocket-id
Building subPackage ./internal/utils/cookie
Building subPackage ./internal/utils/crypto
Building subPackage ./internal/utils/email
Building subPackage ./internal/utils/image
Building subPackage ./internal/utils/jwk
Building subPackage ./internal/utils/signals
Building subPackage ./internal/utils/sqlite
Building subPackage ./internal/utils/systemd
Building subPackage ./internal/utils/testing
Building subPackage ./resources
buildPhase completed in 3 minutes 23 seconds
Running phase: checkPhase
@nix { "action": "setPhase", "phase": "checkPhase" }
panic: open /etc/protocols: operation not permitted

goroutine 1 [running]:
modernc.org/libc/honnef.co/go/netdb.init.0()
/nix/build/nix-build-pocket-id-1.10.0.drv-18387-3763314652/source/backend/vendor/modernc.org/libc/honnef.co/go/netdb/netdb.go:700 +0x5b8
FAIL github.com/pocket-id/pocket-id/backend/internal/bootstrap 0.044s
FAIL

wakapi
Building subPackage ./routes/relay
Building subPackage ./routes/utils
Building subPackage ./services
Building subPackage ./services/imports
Building subPackage ./services/mail
Building subPackage ./static/docs
Building subPackage ./utils
Building subPackage ./utils/fs
Building subPackage ./views
Building subPackage ./views/mail
buildPhase completed in 1 minutes 27 seconds
Running phase: checkPhase
@nix { "action": "setPhase", "phase": "checkPhase" }
panic: open /etc/protocols: operation not permitted

goroutine 1 [running]:
modernc.org/libc/honnef.co/go/netdb.init.0()
/nix/build/nix-build-wakapi-2.15.0.drv-18387-3763314659/source/vendor/modernc.org/libc/honnef.co/go/netdb/netdb.go:700 +0x5b8
FAIL github.com/muety/wakapi/config 0.027s
FAIL

@K900
Copy link
Contributor

K900 commented Sep 8, 2025

This is a ~world rebuild on staging-next, where Go 1.25 is default. I'll revert it there, and please reland in the next cycle.

@c4patino
Copy link
Contributor Author

c4patino commented Sep 8, 2025

This is a ~world rebuild on staging-next, where Go 1.25 is default. I'll revert it there, and please reland in the next cycle.

Hi! Im a bit unfamiliar with that terminology, I've never had to interact with staging-next before. Could you explain what that means for me?

@K900
Copy link
Contributor

K900 commented Sep 8, 2025

@zowoq
Copy link
Contributor

zowoq commented Sep 8, 2025

#441125

@leonklingele
Copy link
Contributor

Hey guys :) I'm really wondering when this change will get included in unstable. It's been a month already since this was merged, yet even after #444862 got merged yesterday, the unstable still runs Go 1.25.0. Thanks for helping!

@emilylange
Copy link
Member

emilylange commented Oct 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Request: go_1_25 1.25.0 -> 1.25.1

8 participants